Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 10824257: Add ManagedModeURLFilter. (Closed)

Created:
8 years, 4 months ago by Bernhard Bauer
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add ManagedModeURLFilter. ManagedModeURLFilter will eventually allow special treatment (e.g. blocking, notifying) for URLs that aren't on a defined whitelist. BUG=134417 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151993

Patch Set 1 #

Patch Set 2 : android compile fix? #

Patch Set 3 : android compile fix? #

Patch Set 4 : fix??? #

Patch Set 5 : . #

Total comments: 14

Patch Set 6 : review #

Total comments: 2

Patch Set 7 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -13 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/managed_mode.h View 1 2 3 4 7 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/managed_mode.cc View 1 2 3 4 5 6 chunks +82 lines, -9 lines 0 comments Download
A chrome/browser/managed_mode_url_filter.h View 1 2 3 4 5 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/managed_mode_url_filter.cc View 1 2 3 4 1 chunk +104 lines, -0 lines 0 comments Download
A chrome/browser/managed_mode_url_filter_unittest.cc View 1 chunk +172 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 1 2 3 4 5 6 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 3 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Bernhard Bauer
Please review. Will: IOThread/ProfileIOData Dominic: Rest Thanks!
8 years, 4 months ago (2012-08-14 08:19:57 UTC) #1
battre
http://codereview.chromium.org/10824257/diff/12001/chrome/browser/managed_mode.cc File chrome/browser/managed_mode.cc (right): http://codereview.chromium.org/10824257/diff/12001/chrome/browser/managed_mode.cc#newcode273 chrome/browser/managed_mode.cc:273: UpdateWhitelist(); missing a break here? http://codereview.chromium.org/10824257/diff/12001/chrome/browser/managed_mode.cc#newcode318 chrome/browser/managed_mode.cc:318: registrar_.Remove(this, chrome::NOTIFICATION_EXTENSION_LOADED, ...
8 years, 4 months ago (2012-08-14 11:58:33 UTC) #2
Bernhard Bauer
http://codereview.chromium.org/10824257/diff/12001/chrome/browser/managed_mode.cc File chrome/browser/managed_mode.cc (right): http://codereview.chromium.org/10824257/diff/12001/chrome/browser/managed_mode.cc#newcode273 chrome/browser/managed_mode.cc:273: UpdateWhitelist(); On 2012/08/14 11:58:33, battre wrote: > missing a ...
8 years, 4 months ago (2012-08-14 15:36:57 UTC) #3
willchan no longer on Chromium
Please update the changelist description much more thoroughly. Explain what ManagedModeURLFilter is. Other than that, ...
8 years, 4 months ago (2012-08-14 17:12:29 UTC) #4
Bernhard Bauer
http://codereview.chromium.org/10824257/diff/6002/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): http://codereview.chromium.org/10824257/diff/6002/chrome/browser/net/chrome_network_delegate.cc#newcode194 chrome/browser/net/chrome_network_delegate.cc:194: #if !defined(OS_ANDROID) On 2012/08/14 17:12:29, willchan wrote: > Why ...
8 years, 4 months ago (2012-08-14 23:36:32 UTC) #5
battre
lgtm
8 years, 4 months ago (2012-08-16 14:35:25 UTC) #6
Bernhard Bauer
Ben, can I get an OWNERS review for chrome/?
8 years, 4 months ago (2012-08-16 14:47:05 UTC) #7
Bernhard Bauer
*Ahem* actually adding Ben. Ben, can I get an OWNERS review for chrome/?
8 years, 4 months ago (2012-08-16 14:47:31 UTC) #8
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-16 17:59:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10824257/6002
8 years, 4 months ago (2012-08-16 18:18:23 UTC) #10
commit-bot: I haz the power
Try job failure for 10824257-6002 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-16 18:48:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10824257/13004
8 years, 4 months ago (2012-08-16 19:24:33 UTC) #12
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 00:08:20 UTC) #13
Change committed as 151993

Powered by Google App Engine
This is Rietveld 408576698