Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: sync/notifier/sync_notifier_factory_unittest.cc

Issue 10824252: Revert 150990 - [Sync] Avoid unregistering object IDs on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/sync_notifier.h ('k') | sync/notifier/sync_notifier_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/sync_notifier_factory_unittest.cc
===================================================================
--- sync/notifier/sync_notifier_factory_unittest.cc (revision 150991)
+++ sync/notifier/sync_notifier_factory_unittest.cc (working copy)
@@ -61,9 +61,8 @@
#else
ASSERT_TRUE(notifier.get());
ObjectIdSet ids = ModelTypeSetToObjectIdSet(ModelTypeSet(syncer::BOOKMARKS));
- notifier->RegisterHandler(&mock_observer_);
notifier->UpdateRegisteredIds(&mock_observer_, ids);
- notifier->UnregisterHandler(&mock_observer_);
+ notifier->UpdateRegisteredIds(&mock_observer_, ObjectIdSet());
#endif
}
@@ -80,9 +79,8 @@
#else
ASSERT_TRUE(notifier.get());
ObjectIdSet ids = ModelTypeSetToObjectIdSet(ModelTypeSet(syncer::BOOKMARKS));
- notifier->RegisterHandler(&mock_observer_);
notifier->UpdateRegisteredIds(&mock_observer_, ids);
- notifier->UnregisterHandler(&mock_observer_);
+ notifier->UpdateRegisteredIds(&mock_observer_, ObjectIdSet());
#endif
}
« no previous file with comments | « sync/notifier/sync_notifier.h ('k') | sync/notifier/sync_notifier_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698