Revert 150990 - [Sync] Avoid unregistering object IDs on shutdown

Revert 150990 - [Sync] Avoid unregistering object IDs on shutdown

Add RegisterHandler() and UnregisterHandler(), which should be called before and after calls to UpdateRegisteredIds().  Use UnregisterHandler() on
shutdown instead of UpdateRegisteredIds(_, ObjectIdSet()).

Make SyncNotifierHelper non-thread-safe.  Fix test breakages that this revealed.  Also add GetAllRegisteredIds() instead of making it the return value of UpdateRegisteredIds().

Propagate UpdateRegisteredIds()/RegisterHandler()/UnregisterHandler() all
the way up to ProfileSyncService.

Make FakeSyncManager be created on the sync thread.

Clean up SyncBackendHost startup/shutdown behavior a bit.

BUG=140325
Review URL: https://chromiumcodereview.appspot.com/10824161

TBR=akalin@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150992

[jeremya, 2012-08-10 05:04:28]

Hi akalin,

This patch caused
ProfileSyncServiceTest.UpdateRegisteredInvalidationIdsPersistence to fail:
http://build.chromium.org/p/chromium/builders/Linux%20Tests%20x64/builds/25272

Please take a look :)

Thanks!


On Fri, Aug 10, 2012 at 2:40 PM, <jeremya@chromium.org> wrote:

> Reviewers: akalin,
>
> Description:
> Revert 150990 - [Sync] Avoid unregistering object IDs on shutdown
>
> Add RegisterHandler() and UnregisterHandler(), which should be called
> before and
> after calls to UpdateRegisteredIds().  Use UnregisterHandler() on
> shutdown instead of UpdateRegisteredIds(_, ObjectIdSet()).
>
> Make SyncNotifierHelper non-thread-safe.  Fix test breakages that this
> revealed.
>  Also add GetAllRegisteredIds() instead of making it the return value of
> UpdateRegisteredIds().
>
> Propagate UpdateRegisteredIds()/**RegisterHandler()/**UnregisterHandler()
> all
> the way up to ProfileSyncService.
>
> Make FakeSyncManager be created on the sync thread.
>
> Clean up SyncBackendHost startup/shutdown behavior a bit.
>
> BUG=140325
>
>
> Review URL:
https://chromiumcodereview.**appspot.com/10824161<https://chromiumcodereview....
>
> TBR=akalin@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/10824252/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     chrome/browser/sync/glue/**bridged_sync_notifier.h
>   M     chrome/browser/sync/glue/**bridged_sync_notifier.cc
>   M     chrome/browser/sync/glue/**bridged_sync_notifier_**unittest.cc
>   M     chrome/browser/sync/glue/**chrome_sync_notification_**bridge.h
>   M     chrome/browser/sync/glue/**chrome_sync_notification_**bridge.cc
>   M     chrome/browser/sync/glue/**chrome_sync_notification_**
> bridge_unittest.cc
>   M     chrome/browser/sync/glue/sync_**backend_host.h
>   M     chrome/browser/sync/glue/sync_**backend_host.cc
>   M     chrome/browser/sync/glue/sync_**backend_host_unittest.cc
>   M     chrome/browser/sync/profile_**sync_service.h
>   M     chrome/browser/sync/profile_**sync_service.cc
>   M     chrome/browser/sync/profile_**sync_service_unittest.cc
>   M     sync/internal_api/public/sync_**manager.h
>   M     sync/internal_api/public/test/**fake_sync_manager.h
>   M     sync/internal_api/sync_**manager_impl.h
>   M     sync/internal_api/sync_**manager_impl.cc
>   M     sync/internal_api/sync_**manager_impl_unittest.cc
>   M     sync/internal_api/test/fake_**sync_manager.cc
>   M     sync/notifier/invalidation_**notifier.h
>   M     sync/notifier/invalidation_**notifier.cc
>   M     sync/notifier/invalidation_**notifier_unittest.cc
>   M     sync/notifier/non_blocking_**invalidation_notifier.h
>   M     sync/notifier/non_blocking_**invalidation_notifier.cc
>   M     sync/notifier/non_blocking_**invalidation_notifier_**unittest.cc
>   M     sync/notifier/p2p_notifier.h
>   M     sync/notifier/p2p_notifier.cc
>   M     sync/notifier/p2p_notifier_**unittest.cc
>   M     sync/notifier/sync_notifier.h
>   M     sync/notifier/sync_notifier_**factory_unittest.cc
>   A  +  sync/notifier/sync_notifier_**helper.h
>   A  +  sync/notifier/sync_notifier_**helper.cc
>   A  +  sync/notifier/sync_notifier_**helper_unittest.cc
>   D     sync/notifier/sync_notifier_**registrar.h
>   D     sync/notifier/sync_notifier_**registrar.cc
>   D     sync/notifier/sync_notifier_**registrar_unittest.cc
>   M     sync/sync.gyp
>   M     sync/tools/sync_listen_**notifications.cc
>
>
>