Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10824247: Remove GestureEvent interface, and rename GestureEventImpl to GestureEvent. (Closed)

Created:
8 years, 4 months ago by sadrul
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, Ben Goodger (Google)
Visibility:
Public.

Description

Remove GestureEvent interface, and rename GestureEventImpl to GestureEvent. This also includes some changes in RenderWidgetHostViewWin to change the way it creates gesture events. BUG=125937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151044

Patch Set 1 #

Patch Set 2 : self-nit #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -255 lines) Patch
M ash/accelerators/accelerator_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/app_list_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overlay_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overlay_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_window_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/shelf_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/system_gesture_event_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M ash/wm/system_modal_container_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_modality_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_modality_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 4 chunks +57 lines, -87 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/root_window.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/shared/compound_event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/shared/compound_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/input_method_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/input_method_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/event.h View 1 3 chunks +18 lines, -21 lines 0 comments Download
M ui/base/event.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ui/base/gestures/gesture_types.h View 2 chunks +1 line, -19 lines 0 comments Download
M ui/views/events/event_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_window_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
sky@ There are some code-cleanup changes in render_widget_host_view_win.cc. The rest is renaming GestureEventImpl to GestureEvent ...
8 years, 4 months ago (2012-08-09 23:48:46 UTC) #1
sky
8 years, 4 months ago (2012-08-10 16:05:16 UTC) #2 
nice LGTM

Powered by Google App Engine
This is Rietveld 408576698