Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 10824246: add glibc support to examples (Closed)

Created:
8 years, 4 months ago by Sam Clegg
Modified:
8 years, 4 months ago
Reviewers:
noelallen1, binji
CC:
chromium-reviews
Visibility:
Public.

Description

add glibc support to examples BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151300

Patch Set 1 #

Total comments: 2

Patch Set 2 : add pnacl to tumbler example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M native_client_sdk/src/examples/fullscreen_tumbler/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_gles/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tumbler/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Sam Clegg
8 years, 4 months ago (2012-08-09 22:43:00 UTC) #1
binji
lgtm http://codereview.chromium.org/10824246/diff/1/native_client_sdk/src/examples/tumbler/example.dsc File native_client_sdk/src/examples/tumbler/example.dsc (right): http://codereview.chromium.org/10824246/diff/1/native_client_sdk/src/examples/tumbler/example.dsc#newcode2 native_client_sdk/src/examples/tumbler/example.dsc:2: 'TOOLS': ['newlib', 'glibc'], can you see if we ...
8 years, 4 months ago (2012-08-09 22:44:03 UTC) #2
Sam Clegg
http://codereview.chromium.org/10824246/diff/1/native_client_sdk/src/examples/tumbler/example.dsc File native_client_sdk/src/examples/tumbler/example.dsc (right): http://codereview.chromium.org/10824246/diff/1/native_client_sdk/src/examples/tumbler/example.dsc#newcode2 native_client_sdk/src/examples/tumbler/example.dsc:2: 'TOOLS': ['newlib', 'glibc'], On 2012/08/09 22:44:04, binji wrote: > ...
8 years, 4 months ago (2012-08-10 00:44:15 UTC) #3
binji
On 2012/08/10 00:44:15, Sam Clegg wrote: > http://codereview.chromium.org/10824246/diff/1/native_client_sdk/src/examples/tumbler/example.dsc > File native_client_sdk/src/examples/tumbler/example.dsc (right): > > http://codereview.chromium.org/10824246/diff/1/native_client_sdk/src/examples/tumbler/example.dsc#newcode2 ...
8 years, 4 months ago (2012-08-10 17:20:37 UTC) #4
noelallen1
Please make sure to run: <chrome>/src/nativeclient_sdk/src/sdktry.sh <cl> To test changes affecting the SDK since the ...
8 years, 4 months ago (2012-08-10 20:43:12 UTC) #5
Sam Clegg
On 2012/08/10 20:43:12, noelallen1 wrote: > Please make sure to run: > <chrome>/src/nativeclient_sdk/src/sdktry.sh <cl> > ...
8 years, 4 months ago (2012-08-11 00:41:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10824246/2003
8 years, 4 months ago (2012-08-11 01:23:41 UTC) #7
commit-bot: I haz the power
Try job failure for 10824246-2003 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-11 03:47:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10824246/2003
8 years, 4 months ago (2012-08-13 16:17:12 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 17:40:43 UTC) #10
Change committed as 151300

Powered by Google App Engine
This is Rietveld 408576698