Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 10824242: This adds Cros API for calling the "Refresh" function on shill's (Closed)

Created:
8 years, 4 months ago by Greg Spencer (Chromium)
Modified:
8 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paul Stewart
Visibility:
Public.

Description

This adds Cros API for calling the "Refresh" function on shill's IPConfig interface. BUG=chromium-os:33223, chromium:129052 TEST=built and tested with another in-process CL that will use it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150921

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Fixed indentation nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -23 lines) Patch
M chrome/browser/chromeos/cros/cros_network_functions.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/mock_network_library.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.h View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.cc View 1 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_stub.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_stub.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/flimflam_device_client.cc View 12 chunks +2 lines, -14 lines 0 comments Download
M chromeos/dbus/flimflam_ipconfig_client.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/flimflam_ipconfig_client.cc View 6 chunks +15 lines, -8 lines 0 comments Download
M chromeos/dbus/mock_flimflam_ipconfig_client.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Greg Spencer (Chromium)
Steven, this adds support for Paul's new API that refreshes the IP config after service ...
8 years, 4 months ago (2012-08-09 20:28:32 UTC) #1
stevenjb
LGTM http://codereview.chromium.org/10824242/diff/1001/chrome/browser/chromeos/cros/network_library_impl_cros.cc File chrome/browser/chromeos/cros/network_library_impl_cros.cc (right): http://codereview.chromium.org/10824242/diff/1001/chrome/browser/chromeos/cros/network_library_impl_cros.cc#newcode466 chrome/browser/chromeos/cros/network_library_impl_cros.cc:466: weak_ptr_factory_.GetWeakPtr())); nit: alignment
8 years, 4 months ago (2012-08-09 20:45:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10824242/26
8 years, 4 months ago (2012-08-09 21:14:06 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 22:31:46 UTC) #4
Change committed as 150921

Powered by Google App Engine
This is Rietveld 408576698