Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10824241: Really ignore events for replacement content in the webnavigation api (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 4 months ago
Reviewers:
marja
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Really ignore events for replacement content in the webnavigation api and discard a pending RVH if the primary one crashes BUG=139117 TEST=no flakiness Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151022

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 3 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
Hey Matt, got time for a short review?
8 years, 4 months ago (2012-08-09 19:51:30 UTC) #1
marja
Rubberstamp LGTM, assuming it really fixes the issue.
8 years, 4 months ago (2012-08-09 20:19:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10824241/1
8 years, 4 months ago (2012-08-09 20:19:56 UTC) #3
jochen (gone - plz use gerrit)
there was still some flakiness. I cycled through the webnavigation test and the captive portal ...
8 years, 4 months ago (2012-08-09 23:10:04 UTC) #4
marja
still lgtm
8 years, 4 months ago (2012-08-10 11:02:42 UTC) #5
jochen (gone - plz use gerrit)
I removed the test-reenabling to make merging less of a nightmare
8 years, 4 months ago (2012-08-10 11:13:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10824241/11002
8 years, 4 months ago (2012-08-10 11:13:36 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 13:06:59 UTC) #8 
Change committed as 151022

Powered by Google App Engine
This is Rietveld 408576698