Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 10824237: Fix a bug in pyauto.py where JavascriptRuntimeError is raised but not imported. (Closed)

Created:
8 years, 4 months ago by fdeng1
Modified:
8 years, 4 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Fix a bug in pyauto.py where JavascriptRuntimeError is raised but not imported. Import pyauto_errors.JavascriptRuntimeError so that AddDomMutationObserver can raise it correctly. BUG=None TEST= NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/test/pyautolib/pyauto.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
fdeng1
Hi Dennis and Nirnimesh, I think this is a bug. Would you please take a ...
8 years, 4 months ago (2012-08-09 16:56:58 UTC) #1
dennis_jeffrey
I think you're right. LGTM.
8 years, 4 months ago (2012-08-09 17:01:40 UTC) #2
Nirnimesh
LGTM
8 years, 4 months ago (2012-08-09 17:29:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdeng@chromium.org/10824237/1
8 years, 4 months ago (2012-08-09 17:41:16 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 17:42:20 UTC) #5
Change committed as 150837

Powered by Google App Engine
This is Rietveld 408576698