Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 10824229: Add out-of-line copy ctor to Maps::Iterator. (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Markus (顧孟勤)
Visibility:
Public.

Description

Add out-of-line copy ctor to Maps::Iterator. Chrome's style checking plugin complains that this class needs an explicit out-of-line copy constructor. So far, the style plugin has not warned about nested classes because of a bug, but we have fixed that bug and are now cleaning up all the cases where it warns. Committed on behalf of Hans Wennborg (hans@chromium.org). BUG=http://code.google.com/p/chromium/issues/detail?id=139346 Committed: https://code.google.com/p/seccompsandbox/source/detail?r=187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M maps.h View 1 chunk +1 line, -0 lines 0 comments Download
M maps.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
mseaborn: can you take a look?
8 years, 4 months ago (2012-08-09 09:54:20 UTC) #1
hans
Ping? This is the last remaining piece of a relatively large clean-up, so would be ...
8 years, 4 months ago (2012-08-13 09:10:12 UTC) #2
Mark Seaborn
LGTM
8 years, 4 months ago (2012-08-13 16:15:45 UTC) #3
Mark Seaborn
I've committed it for you. Sorry for the delay! Mark
8 years, 4 months ago (2012-08-14 00:49:08 UTC) #4
hans
8 years, 4 months ago (2012-08-14 07:27:22 UTC) #5
On 2012/08/14 00:49:08, Mark Seaborn wrote:
> I've committed it for you.  Sorry for the delay!

No problem, thanks for your help.

Powered by Google App Engine
This is Rietveld 408576698