Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 10824223: Diagnostics UI: apply UI styles. (Closed)

Created:
8 years, 4 months ago by hshi1
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Diagnostics UI: apply UI styles. Add a navigation pane on the left (similar to the uber frame for history/extensions/settings pages) and apply the same style settings. Note: the navigation pane is non-functional at the moment. For Diagnostics V1 (1st milestone), we will only have a single page for connectivity, which is always selected as the current page. BUG=139442 TEST=lumpy Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150793

Patch Set 1 : Polish: no need to set -webkit-margin- and color. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/diagnostics/main.css View 1 chunk +37 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/diagnostics/main.html View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hshi1
Please take a look. This patch is for UI style tweak only; no functionality change. ...
8 years, 4 months ago (2012-08-09 00:29:49 UTC) #1
satorux1
LGTM. Just curious but is this page designed by UX folks?
8 years, 4 months ago (2012-08-09 09:36:09 UTC) #2
hshi1
On 2012/08/09 09:36:09, satorux1 wrote: > LGTM. Just curious but is this page designed by ...
8 years, 4 months ago (2012-08-09 13:30:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/10824223/5002
8 years, 4 months ago (2012-08-09 13:30:34 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 15:10:20 UTC) #5
Change committed as 150793

Powered by Google App Engine
This is Rietveld 408576698