Issue 10824219: Fixes bug where launcher background would remain painted when it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824219: Fixes bug where launcher background would remain painted when it (Closed)

Created:
8 years, 4 months ago by sky

Modified:
8 years, 4 months ago

Reviewers:
Mr4D (OOO till 08-26)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes bug where launcher background would remain painted when it shouldn't. We need to invoke UpdateShelfVisibility after BaseLayoutManager::ShowStateChanged since it ShowStateChanged() may change the visiblity of the window, which effects what UpdateShelfVisibility returns. BUG=141391 TEST=covered by unit tests R=skuhne@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150592

Patch Set 1 #

Patch Set 2 : Comment tweaks #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
M	ash/launcher/background_animator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/launcher/launcher.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_layout_manager.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager_unittest.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mr4D (OOO till 08-26)

lgtm Ahh. Yeah, that was one of the many places which catched my eye, but ...

8 years, 4 months ago (2012-08-08 17:16:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10824219/2001

8 years, 4 months ago (2012-08-08 17:18:02 UTC) #3

Change committed as 150592

Expand Messages | Collapse Messages