Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: chrome/browser/extensions/pack_extension_job.h

Issue 10824204: Move small c/b/extensions classes into extensions namespace no.2 (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Latest master for cq + nitfix Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/navigation_observer.cc ('k') | chrome/browser/extensions/pack_extension_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/pack_extension_job.h
diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h
index 78027de2f0888eebb913cfb41e5558b0ae163ec6..4039d197dc3276f29e1d0b3f0fdaffa477270f70 100644
--- a/chrome/browser/extensions/pack_extension_job.h
+++ b/chrome/browser/extensions/pack_extension_job.h
@@ -13,6 +13,7 @@
#include "content/public/browser/browser_thread.h"
#include "chrome/browser/extensions/extension_creator.h"
+namespace extensions {
// Manages packing an extension on the file thread and reporting the result
// back to the UI.
@@ -23,9 +24,8 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
public:
virtual void OnPackSuccess(const FilePath& crx_file,
const FilePath& key_file) = 0;
- virtual void OnPackFailure(
- const std::string& message,
- extensions::ExtensionCreator::ErrorType error_type) = 0;
+ virtual void OnPackFailure(const std::string& message,
+ ExtensionCreator::ErrorType error_type) = 0;
protected:
virtual ~Client() {}
@@ -57,9 +57,8 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
// If |asynchronous_| is false, this is run on whichever thread calls it.
void Run();
void ReportSuccessOnClientThread();
- void ReportFailureOnClientThread(
- const std::string& error,
- extensions::ExtensionCreator::ErrorType error_type);
+ void ReportFailureOnClientThread(const std::string& error,
+ ExtensionCreator::ErrorType error_type);
content::BrowserThread::ID client_thread_id_;
Client* client_;
@@ -73,4 +72,6 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
DISALLOW_COPY_AND_ASSIGN(PackExtensionJob);
};
+} // namespace extensions
+
#endif // CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_H_
« no previous file with comments | « chrome/browser/extensions/navigation_observer.cc ('k') | chrome/browser/extensions/pack_extension_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698