Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 10824204: Move small c/b/extensions classes into extensions namespace no.2 (Closed)

Created:
8 years, 4 months ago by Devlin
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, tfarina, jeremya+watch_chromium.org, Aaron Boodman, kinuko+watch
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move small c/b/extensions classes into extensions namespace no.2 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - ExtensionDataDeleter (now extensions::DataDeleter) - ExtensionNavigationObserver (now extensions::NavigationObserver) - PackExtensionJob - PlatformAppBrowsertest - ShellWindowRegistry - ExtensionStartupUtil (see note in file) BUG=117261 TBR=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151535

Patch Set 1 #

Total comments: 3

Patch Set 2 : Latest master for cq + nitfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -721 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_tag_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/extensions/data_deleter.h View 4 chunks +16 lines, -14 lines 0 comments Download
A + chrome/browser/extensions/data_deleter.cc View 6 chunks +26 lines, -26 lines 0 comments Download
D chrome/browser/extensions/extension_data_deleter.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/extensions/extension_data_deleter.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/extensions/extension_navigation_observer.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/extensions/extension_navigation_observer.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
D chrome/browser/extensions/extensions_startup.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/extensions/extensions_startup.cc View 1 chunk +0 lines, -75 lines 0 comments Download
A + chrome/browser/extensions/navigation_observer.h View 3 chunks +15 lines, -9 lines 0 comments Download
A + chrome/browser/extensions/navigation_observer.cc View 8 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.h View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.cc View 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.h View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/platform_app_launcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/settings/settings_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/shell_window_registry.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/shell_window_registry.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/startup_helper.h View 3 chunks +13 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/startup_helper.cc View 5 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Devlin
https://chromiumcodereview.appspot.com/10824204/diff/1/chrome/browser/extensions/extensions_startup.h File chrome/browser/extensions/extensions_startup.h (left): https://chromiumcodereview.appspot.com/10824204/diff/1/chrome/browser/extensions/extensions_startup.h#oldcode17 chrome/browser/extensions/extensions_startup.h:17: ExtensionsStartupUtil(); I renamed ExtensionsStartupUtil to be extensions::StartupHelper. This way, ...
8 years, 4 months ago (2012-08-09 18:41:51 UTC) #1
Devlin
Please review when you have a chance: asargent: c/b/extensions/ pkasting: c/b/ui/ Thanks in advance :)
8 years, 4 months ago (2012-08-09 18:43:42 UTC) #2
asargent_no_longer_on_chrome
lgtm
8 years, 4 months ago (2012-08-09 22:16:38 UTC) #3
Peter Kasting
LGTM https://chromiumcodereview.appspot.com/10824204/diff/1/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc File chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc (right): https://chromiumcodereview.appspot.com/10824204/diff/1/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc#newcode711 chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc:711: id_to_item_map_[id].app_id); Nit: Indent 4 more
8 years, 4 months ago (2012-08-11 22:49:17 UTC) #4
Devlin
https://chromiumcodereview.appspot.com/10824204/diff/1/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc File chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc (right): https://chromiumcodereview.appspot.com/10824204/diff/1/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc#newcode711 chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc:711: id_to_item_map_[id].app_id); On 2012/08/11 22:49:17, Peter Kasting wrote: > Nit: ...
8 years, 4 months ago (2012-08-14 17:43:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10824204/5002
8 years, 4 months ago (2012-08-14 17:46:55 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 19:21:40 UTC) #7
Change committed as 151535

Powered by Google App Engine
This is Rietveld 408576698