Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: chrome/browser/chromeos/login/webui_login_display_host.h

Issue 10824203: Initialize OOBE/login WebUI in hidden state in parallel with wallpaper animation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix how login prompt-visible is emitted Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/window_animations.cc ('k') | chrome/browser/chromeos/login/webui_login_display_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/webui_login_display_host.h
diff --git a/chrome/browser/chromeos/login/webui_login_display_host.h b/chrome/browser/chromeos/login/webui_login_display_host.h
index c2fb95df23b4bb16b69a70383f03d9166c52d87d..8e710b4b0cac4e2b9a97d34e0f4660397e69e49e 100644
--- a/chrome/browser/chromeos/login/webui_login_display_host.h
+++ b/chrome/browser/chromeos/login/webui_login_display_host.h
@@ -67,6 +67,9 @@ class WebUILoginDisplayHost : public BaseLoginDisplayHost,
// Loads given URL. Creates WebUILoginView if needed.
void LoadURL(const GURL& url);
+ // Shows OOBE/sign in WebUI that was previously initialized in hidden state.
+ void ShowWebUI();
+
// Starts postponed WebUI (OOBE/sign in) if it was waiting for
// wallpaper animation end.
void StartPostponedWebUI();
@@ -87,10 +90,20 @@ class WebUILoginDisplayHost : public BaseLoginDisplayHost,
// received.
bool is_wallpaper_loaded_;
+ // True if WebUI is initialized hidden in parallel with wallpaper animation.
+ // Otherwise it is postponed and only starts initializing when animation
+ // finishes. Makes sense only if |waiting_for_wallpaper_load_| is true.
+ // By default is true. Could be used to tune performance if needed.
+ bool initialize_webui_in_parallel_;
+
+ // Stores status area current visibility to be applied once login WebUI
+ // is shown.
+ bool status_area_saved_visibility_;
+
// True if should not show WebUI on first StartWizard/StartSignInScreen call
// but wait for wallpaper load animation to finish.
- // Used in OOBE (first boot, boot after update) i.e. till
- // device is marked as registered to postpone loading OOBE screen / sign in.
+ // OOBE/sign in WebUI is either initialized hidden or postponed i.e. loaded
+ // only when wallpaper animation finishes.
bool waiting_for_wallpaper_load_;
content::NotificationRegistrar registrar_;
« no previous file with comments | « ash/wm/window_animations.cc ('k') | chrome/browser/chromeos/login/webui_login_display_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698