Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10824203: Initialize OOBE/login WebUI in hidden state in parallel with wallpaper animation. (Closed)

Created:
8 years, 4 months ago by Nikita (slow)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Initialize OOBE/login WebUI in hidden state in parallel with wallpaper animation. * Boot time animation decreased from 2s to 1s (for both OOBE / normal boot). * WebUI is initialized in hidden state in parallel with wallpaper animation. * Using EASE_OUT instead of LINEAR for boot animation. BUG=140858 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150535

Patch Set 1 #

Total comments: 12

Patch Set 2 : review (comments + flag) #

Patch Set 3 : merge #

Patch Set 4 : m #

Patch Set 5 : fix how login prompt-visible is emitted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -11 lines) Patch
M ash/wm/window_animations.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.h View 1 2 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.cc View 1 2 3 4 10 chunks +56 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 1 2 3 4 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 3 4 4 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
8 years, 4 months ago (2012-08-07 19:52:46 UTC) #1
Nikita (slow)
+Ben for ash/* OWNERS review.
8 years, 4 months ago (2012-08-08 05:30:02 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-08 05:31:40 UTC) #3
Ivan Korotkov
lgtm http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/webui_login_display_host.cc File chrome/browser/chromeos/login/webui_login_display_host.cc (right): http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/webui_login_display_host.cc#newcode82 chrome/browser/chromeos/login/webui_login_display_host.cc:82: // initialize_webui_in_parallel_ value is ignored through the code ...
8 years, 4 months ago (2012-08-08 05:53:48 UTC) #4
Nikita (slow)
http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/webui_login_display_host.cc File chrome/browser/chromeos/login/webui_login_display_host.cc (right): http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/webui_login_display_host.cc#newcode82 chrome/browser/chromeos/login/webui_login_display_host.cc:82: // initialize_webui_in_parallel_ value is ignored through the code flow. ...
8 years, 4 months ago (2012-08-08 06:25:39 UTC) #5
Nikita (slow)
8 years, 4 months ago (2012-08-08 06:25:39 UTC) #6 
http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/webui_login_display_host.cc (right):

http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display_host.cc:82: //
initialize_webui_in_parallel_ value is ignored through the code flow.
On 2012/08/08 05:53:48, Ivan Korotkov wrote:
> |...|

Done.

http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display_host.cc:229: // If we're going
through a normal path i.e. not boot path when waiting
On 2012/08/08 05:53:48, Ivan Korotkov wrote:
> "If" is misleading here

Done.

http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display_host.cc:231: // If we're
waiting for wallpaper load then show WebUI right away if it was
On 2012/08/08 05:53:48, Ivan Korotkov wrote:
> If we're not ..., maybe?

Done.

http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/webui_login_display_host.h (right):

http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display_host.h:95: // finishes. Makes
sense only if waiting_for_wallpaper_load_ is true.
On 2012/08/08 05:53:48, Ivan Korotkov wrote:
> |waiting_for_wallpaper_load_|

Done.

http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display_host.h:96: // By default is
true. Could be used to tune performance if needed.
On 2012/08/08 05:53:48, Ivan Korotkov wrote:
> Maybe make it a command-line flag? Or a constant?

Done.

http://codereview.chromium.org/10824203/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display_host.h:104: // but wait for
wallpaper load animation to finish. Used in to postpone
On 2012/08/08 05:53:48, Ivan Korotkov wrote:
> Used in... ?

Done.

Powered by Google App Engine
This is Rietveld 408576698