Verify at method exit that stack size is the same as at entry, except for methods with finally clau…

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 77 matching lines @@
     __ LoadObject(temp, function);
     __ pushl(result);  // Preserve result.
     __ pushl(temp);
     compiler->GenerateCallRuntime(Isolate::kNoDeoptId,
                                   0,
                                   CatchClauseNode::kInvalidTryIndex,
                                   kTraceFunctionExitRuntimeEntry);
     __ popl(temp);  // Remove argument.
     __ popl(result);  // Restore result.
   }
+#if defined(DEBUG)
+  // TODO(srdjan): Fix for functions with finally clause.
+  // A finally clause may leave a previously pushed return value if it
+  // has its own return instruction. Method that have finally are currently
+  // not optimized.
+  if (!compiler->HasFinally()) {
+    Label done;
+    __ movl(EDI, EBP);
+    __ subl(EDI, ESP);
+    // + 1 for Pc marker.
+    __ cmpl(EDI, Immediate((compiler->StackSize() + 1) * kWordSize));
+    __ j(EQUAL, &done, Assembler::kNearJump);
+    __ int3();
+    __ Bind(&done);
+  }
+#endif
   __ LeaveFrame();
   __ ret();
 
   // Generate 1 byte NOP so that the debugger can patch the
   // return pattern with a call to the debug stub.
   __ nop(1);
   compiler->AddCurrentDescriptor(PcDescriptors::kReturn,
                                  deopt_id(),
                                  token_pos(),
                                  CatchClauseNode::kInvalidTryIndex);
@@ skipping 1999 matching lines @@
   ASSERT(locs()->out().reg() == EAX);
   __ CompareObject(locs()->out().reg(), compiler->bool_true());
   EmitBranchOnCondition(compiler, branch_condition);
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64