Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 10824200: Handful of tweaks for tab dragging with touch: (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Handful of tweaks for tab dragging with touch: . Trigger scrolling of visible tabs on a gesture. . Make sure scrolling of visible tabs is triggered if the tabstrip isn't overflowing. . Fixes capture issues when used under aura. . Triggers switching from scroll visible to reorder in a couple of situations. . Increases the vertical distance before detaching with touch and make it so that you can't detach when dragging only horizontally. . Adds tests for touch code path. BUG=140606 TEST=covered by tests R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150481

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -157 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 9 chunks +47 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 35 chunks +287 lines, -123 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/test/event_generator.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/aura/test/event_generator.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
8 years, 4 months ago (2012-08-07 18:19:12 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-07 18:21:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10824200/2001
8 years, 4 months ago (2012-08-07 19:40:33 UTC) #3
commit-bot: I haz the power
Try job failure for 10824200-2001 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-07 22:21:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10824200/5002
8 years, 4 months ago (2012-08-08 00:19:25 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 01:57:19 UTC) #6
Change committed as 150481

Powered by Google App Engine
This is Rietveld 408576698