Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 10824198: Move small c/b/extensions classes into extensions namespace no.1 (Closed)

Created:
8 years, 4 months ago by Devlin
Modified:
8 years, 4 months ago
Reviewers:
csilv, Matt Perry
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152159

Patch Set 1 #

Patch Set 2 : Latest master for cq #

Patch Set 3 : Latest-er master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -241 lines) Patch
A + chrome/browser/extensions/activity_log.h View 1 4 chunks +17 lines, -16 lines 0 comments Download
A + chrome/browser/extensions/activity_log.cc View 1 4 chunks +21 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 5 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/extensions/app_shortcut_manager.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_shortcut_manager.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/autoupdate_interceptor.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/autoupdate_interceptor.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 4 chunks +6 lines, -2 lines 0 comments Download
D chrome/browser/extensions/extension_activity_log.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/extensions/extension_activity_log.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 3 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extension_activity.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_activity_ui.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_activity_ui.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request.h View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
Please review when you have a chance: mpcomplete: c/b/extensions/ csilv: c/b/ui/webui/, c/b/resources/extensions/ Thanks in advance.
8 years, 4 months ago (2012-08-09 18:46:17 UTC) #1
csilv
lgtm
8 years, 4 months ago (2012-08-09 18:54:17 UTC) #2
Matt Perry
lgtm
8 years, 4 months ago (2012-08-15 20:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10824198/7001
8 years, 4 months ago (2012-08-15 22:12:00 UTC) #4
commit-bot: I haz the power
Try job failure for 10824198-7001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-15 22:53:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10824198/7001
8 years, 4 months ago (2012-08-16 22:52:06 UTC) #6
commit-bot: I haz the power
Try job failure for 10824198-7001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-17 00:19:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10824198/2010
8 years, 4 months ago (2012-08-17 18:17:17 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 22:29:40 UTC) #9
Change committed as 152159

Powered by Google App Engine
This is Rietveld 408576698