Issue 10824171: NaCl: Cleanup: Remove PpapiPluginRegisterDefaultThreadCreator()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824171: NaCl: Cleanup: Remove PpapiPluginRegisterDefaultThreadCreator() (Closed)

Created:
8 years, 4 months ago by Mark Seaborn

Modified:
8 years, 4 months ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Cleanup: Remove PpapiPluginRegisterDefaultThreadCreator() This was left over from the transition to the IRT library: it is to make the audio thread work when libppruntime is linked into the user nexe (which is no longer supported) rather than into the IRT. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1691 TEST=run_ppapi_ppb_audio_browser_test (only run on Mac, not Windows or Linux) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150052

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Copyright #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -50 lines)			Patch
M	ppapi/native_client/src/shared/ppapi_proxy/nacl.scons	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/plugin_globals.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	ppapi/native_client/src/shared/ppapi_proxy/plugin_threading.cc	View		1 chunk	+0 lines, -44 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppruntime.h	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages