Cleaned up usage of std::wstring in src/remoting. Added presubmit warning supressions for the reman…

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 274 matching lines @@
 
 
 def _CheckNoNewWStrings(input_api, output_api):
   """Checks to make sure we don't introduce use of wstrings."""
   problems = []
   for f in input_api.AffectedFiles():
     if (not f.LocalPath().endswith(('.cc', '.h')) or
         f.LocalPath().endswith('test.cc')):
       continue
 
+    supressed = False

[Wez, 2012/08/03 21:26:15]

typo: suppressed

I'd suggest calling this allowWString rather than suppressed.

[alexeypa (please no reviews), 2012/08/03 22:00:18]

Done.

     for line_num, line in f.ChangedContents():
-      if 'wstring' in line:
+      if 'presubmit: allow wstring' in line:
+        supressed = True
+      elif not supressed and 'wstring' in line:
         problems.append('    %s:%d' % (f.LocalPath(), line_num))
+        supressed = False
+      else:
+        supressed = False
 
   if not problems:
     return []
   return [output_api.PresubmitPromptWarning('New code should not use wstrings.'
-      '  If you are calling an API that accepts a wstring, fix the API.\n' +
+      '  If you are calling a cross-platform API that accepts a wstring, '
+      'fix the API.\n' +
       '\n'.join(problems))]
 
 
 def _CheckNoDEPSGIT(input_api, output_api):
   """Make sure .DEPS.git is never modified manually."""
   if any(f.LocalPath().endswith('.DEPS.git') for f in
       input_api.AffectedFiles()):
     return [output_api.PresubmitError(
       'Never commit changes to .DEPS.git. This file is maintained by an\n'
       'automated system based on what\'s in DEPS and your changes will be\n'
@@ skipping 252 matching lines @@
 
   trybots = ['win_rel', 'linux_rel', 'mac_rel', 'linux_clang:compile',
              'android']
 
   # Match things like path/aura/file.cc and path/file_aura.cc.
   # Same for chromeos.
   if any(re.search('[/_](aura|chromeos)', f) for f in files):
     trybots += ['linux_chromeos', 'linux_chromeos_clang:compile']
 
   return trybots