Issue 10824146: Remove "All files" filter from the wallpaper image picker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824146: Remove "All files" filter from the wallpaper image picker (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev

Modified:
8 years, 3 months ago

Reviewers:
csilv

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove "All files" filter from the wallpaper image picker BUG=140218 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153474

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Hi Chris, Please review this small patch. This is a follow up to https://chromiumcodereview.appspot.com/10826084/ Thanks, ...

8 years, 4 months ago (2012-08-02 13:26:58 UTC) #1

Vladislav Kaznacheev

Ping? On 2012/08/02 13:26:58, Vladislav Kaznacheev wrote: > Hi Chris, > > Please review this ...

8 years, 4 months ago (2012-08-20 12:56:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10824146/1

8 years, 4 months ago (2012-08-21 18:52:39 UTC) #4

commit-bot: I haz the power

8 years, 4 months ago (2012-08-21 18:52:41 UTC) #5

Failed to apply patch for
chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc:
While running patch -p1 --forward --force;
A         chrome/browser/ui/webui/options2
A         chrome/browser/ui/webui/options2/chromeos
patching file
chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc
Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc.rej

Expand Messages | Collapse Messages