Issue 10824145: Move all the butter bar code to a separate class. Fix some style, method & variable names and simpl…

Issue 10824145: Move all the butter bar code to a separate class. Fix some style, method & variable names and simpl… (Closed)

Created:
8 years, 4 months ago by Oleg Eterevsky

Modified:
8 years, 4 months ago

Reviewers:
Vladislav Kaznacheev, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move all the butter bar code to a separate class. Fix some style, method & variable names and simplify code. BUG=134601 TEST=Progress is shown while copying files. Error messages in butter bar are shown and hidden appropriately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149634

Patch Set 1 #

Patch Set 2 : Fix wrong positioning. #

Patch Set 3 : Fix progress bar. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+278 lines, -225 lines)			Patch
M	chrome/browser/resources/file_manager/css/file_manager.css	View		4 chunks	+7 lines, -7 lines	0 comments	Download
A	chrome/browser/resources/file_manager/js/butter_bar.js	View	1 2	1 chunk	+224 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View		10 chunks	+16 lines, -217 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/main_scripts.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/util.js	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/10824145/8

8 years, 4 months ago (2012-08-02 14:20:32 UTC) #3

commit-bot: I haz the power

Try job failure for 10824145-8 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=49122 Step "update" is always ...

8 years, 4 months ago (2012-08-02 14:22:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/10824145/8

8 years, 4 months ago (2012-08-02 14:29:12 UTC) #5

Change committed as 149634

Expand Messages | Collapse Messages