Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 10824134: Revert 149409 - Roll Syzygy release to r1027 (Closed)

Created:
8 years, 4 months ago by Sigurður Ásgeirsson
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sigurður Ásgeirsson
8 years, 4 months ago (2012-08-01 21:19:30 UTC) #1
Roger McFarlane (Chromium)
8 years, 4 months ago (2012-08-01 21:31:18 UTC) #2
Lgtm
On Aug 1, 2012 5:19 PM, <siggi@chromium.org> wrote:

> Reviewers: Roger McFarlane (Chromium),
>
> Description:
> Revert 149409 - Roll Syzygy release to r1027
>
> This breaks the official canary build PDB source updates.
>
>
https://codereview.appspot.**com/6454073/<https://codereview.appspot.com/6454...
>
> R=siggi@chromium.org,chrisha@**chromium.org <chrisha@chromium.org>
>
> BUG=
>
>
> Review URL:
https://chromiumcodereview.**appspot.com/10826091<https://chromiumcodereview....
>
> TBR=rogerm@chromium.org,dharan**i@google.com <dharani@google.com>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10824134/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     DEPS
>
>
> Index: DEPS
> ==============================**==============================**=======
> --- DEPS        (revision 149492)
> +++ DEPS        (working copy)
> @@ -368,7 +368,7 @@
>      # Binary level profile guided optimizations. This points to the
>      # latest release binaries for the toolchain.
>      "src/third_party/syzygy/**binaries":
> -      (Var("googlecode_url") % "sawbuck") + "/trunk/syzygy/binaries@1027
> ",
> +      (Var("googlecode_url") % "sawbuck") + "/trunk/syzygy/binaries@991",
>
>      # Binaries for nacl sdk.
>      "src/third_party/nacl_sdk_**binaries":
>
>
>

Powered by Google App Engine
This is Rietveld 408576698