Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 10824133: Check in 2x slider bar resources. (Closed)

Created:
8 years, 4 months ago by jennyz
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Check in 2x slider bar resources, also slightly adjust 1x resource files for slider_thumb.png and slider_thumb_disabled.png. BUG=140077 TBR=sky,oshima Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149500

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add back all the png files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-13 lines, --13 lines) Patch
M ui/resources/default_100_percent/slider_thumb.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/slider_thumb_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_center_active.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_center_disabled.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_center_pressed.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_left_active.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_left_disabled.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_left_pressed.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_right_active.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_right_disabled.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_right_pressed.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_thumb.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/slider_thumb_disabled.png View 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/10824133/1
8 years, 4 months ago (2012-08-01 21:07:52 UTC) #1
commit-bot: I haz the power
Presubmit check for 10824133-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-01 21:07:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/10824133/10001
8 years, 4 months ago (2012-08-01 21:18:35 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 21:18:41 UTC) #4
Presubmit check for 10824133-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
Image ui/resources/default_200_percent/slider_center_active.png is 9x13,
expected to be 18x26

Image ui/resources/default_200_percent/slider_center_disabled.png is 9x13,
expected to be 18x26

Image ui/resources/default_200_percent/slider_center_pressed.png is 9x13,
expected to be 18x26

Presubmit checks took 2.3s to calculate.

Powered by Google App Engine
This is Rietveld 408576698