Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 10824127: roll gyp 1441:1446 (Closed)

Created:
8 years, 4 months ago by scottmg
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, qsr, Sam Clegg
Visibility:
Public.

Description

roll gyp 1441:1446 r1442 Allow <(CONFIGURATION_NAME) to be used in path for ninja. r1443 ninja windows: don't spam reg.exe calls if we can't find DirectX installation r1444 make unitests less fragile in the face of debug output changes. r1445 Fixing issues with path. r1446 ninja windows: unfork back to 'depfile' name rather than 'deplist' R=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
(will wait until http://build.chromium.org/f/client/gyp/ has been poked)
8 years, 4 months ago (2012-08-01 16:54:58 UTC) #1
Nico
Lfrm On Aug 1, 2012 9:54 AM, <scottmg@chromium.org> wrote: > Reviewers: Nico, > > Message: ...
8 years, 4 months ago (2012-08-01 16:59:51 UTC) #2
Nico
Mobile keyboards FTL. Lgtm. On Aug 1, 2012 9:59 AM, "Nico Weber" <thakis@chromium.org> wrote: > ...
8 years, 4 months ago (2012-08-01 17:00:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10824127/1
8 years, 4 months ago (2012-08-01 18:32:08 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 20:11:10 UTC) #5
Change committed as 149479

Powered by Google App Engine
This is Rietveld 408576698