chrome/browser/metrics/metrics_service.cc - Issue 10824123: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 10824123: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/metrics_service.cc

===================================================================

--- chrome/browser/metrics/metrics_service.cc (revision 149222)

+++ chrome/browser/metrics/metrics_service.cc (working copy)

@@ -163,6 +163,7 @@

#include "base/values.h"

#include "chrome/browser/autocomplete/autocomplete_log.h"

#include "chrome/browser/bookmarks/bookmark_model.h"

+#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/process_map.h"

@@ -713,7 +714,7 @@

case chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED: {

Profile* p = content::Source<Profile>(source).ptr();

if (p)

- LogBookmarks(p->GetBookmarkModel());

+ LogBookmarks(BookmarkModelFactory::GetForProfile(p));

break;

}

default:

« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/ui/webui/history_ui.cc » ('j') | no next file with comments »