Issue 10824120: Add logging for shaders that don't compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824120: Add logging for shaders that don't compile (Closed)

Created:
8 years, 4 months ago by greggman

Modified:
8 years, 4 months ago

Reviewers:
alokp

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add logging for shaders that don't compile BUG=139409 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149355

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	gpu/command_buffer/service/program_manager.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

alokp

lgtm http://codereview.chromium.org/10824120/diff/1/gpu/command_buffer/service/program_manager.cc File gpu/command_buffer/service/program_manager.cc (right): http://codereview.chromium.org/10824120/diff/1/gpu/command_buffer/service/program_manager.cc#newcode441 gpu/command_buffer/service/program_manager.cc:441: // All translated shaders must compile. Could you ...

8 years, 4 months ago (2012-07-31 23:04:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10824120/1002

8 years, 4 months ago (2012-08-01 00:57:42 UTC) #3

Change committed as 149355

Expand Messages | Collapse Messages

Issue 10824120: Add logging for shaders that don't compile (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages