Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10824111: Include webkit strings in the content shell package (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dmazzoni
Visibility:
Public.

Description

Include webkit strings in the content shell package BUG=none TEST=happier dominic Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149203

Patch Set 1 #

Patch Set 2 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review
8 years, 4 months ago (2012-07-31 14:36:24 UTC) #1
jam
lgtm, thanks
8 years, 4 months ago (2012-07-31 15:07:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10824111/9001
8 years, 4 months ago (2012-07-31 15:09:43 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 16:44:04 UTC) #4
Change committed as 149203

Powered by Google App Engine
This is Rietveld 408576698