Issue 10824107: Fix write barrier for StoreKeyedFastElements on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824107: Fix write barrier for StoreKeyedFastElements on ARM (Closed)

Created:
8 years, 4 months ago by danno

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix write barrier for StoreKeyedFastElements on ARM R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12238

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View	1	4 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 4 months ago (2012-07-31 13:42:32 UTC) #2

LGTM (with one nit).

https://chromiumcodereview.appspot.com/10824107/diff/1/src/arm/lithium-codege...
File src/arm/lithium-codegen-arm.cc (right):

https://chromiumcodereview.appspot.com/10824107/diff/1/src/arm/lithium-codege...
src/arm/lithium-codegen-arm.cc:3859: offset = (ToInteger32(const_operand) +
instr->additional_index()) *
Can we use FixedArray::OffsetOfElementAt() for this?

Expand Messages | Collapse Messages