Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 10824105: Refer to build/mac/find_sdk.py in a more robust way. (Closed)

Created:
8 years, 4 months ago by Peter Beverloo
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, rniwa-cr
Visibility:
Public.

Description

Refer to build/mac/find_sdk.py in a more robust way. This broke the WebKit Mac bot, as the directory it works in is different there compared to the Chromium configuration. Determine the source's root through the DEPTH define, and then walk up in the build/mac/ directory. BUG= TEST=WebKit Mac builder doesn't break after a Chromium DEPS roll. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Beverloo
Per the WebKit gardening thread.
8 years, 4 months ago (2012-07-31 10:38:55 UTC) #1
Nico
On 2012/07/31 10:38:55, Peter Beverloo wrote: > Per the WebKit gardening thread. Lgtm
8 years, 4 months ago (2012-07-31 13:06:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/10824105/1
8 years, 4 months ago (2012-07-31 13:08:17 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 14:38:01 UTC) #4
Change committed as 149181

Powered by Google App Engine
This is Rietveld 408576698