Use json to describe dmprof policies.

Use json to describe dmprof policies.


BUG=123758
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150528

[Dai Mikurube (NOT FULLTIME), 2012-07-31 05:29:20]

Hi Marc,

Thank you for reviewing for my frequent requests.  Could you take a look at this
small change?

It just adds json support for 'policy' files.  Code clean-up is planned in
another change.

[Dai Mikurube (NOT FULLTIME), 2012-08-03 02:37:45]

gentle ping.

[Dai Mikurube (NOT FULLTIME), 2012-08-08 06:39:10]

Hi Jochen,

Could you take a look at this change when you have time?  This file is usually
reviewed by maruel@, but he looks like in vacation.

I know the code is not so clean...  Code clean-up is ongoing in parallel at
another change.

[jochen (gone - plz use gerrit), 2012-08-08 07:36:53]

lgtm

http://codereview.chromium.org/10824104/diff/11001/tools/deep_memory_profiler...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10824104/diff/11001/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof:839: (policy_label, policy_path,
policy.version))
this might end up accessing .version of None. What about adding an else: path
that just returns None?

[Dai Mikurube (NOT FULLTIME), 2012-08-08 07:53:53]

Thank you for reviewing.  Updated the patch.

I'll be committing this change.

http://codereview.chromium.org/10824104/diff/11001/tools/deep_memory_profiler...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10824104/diff/11001/tools/deep_memory_profiler...
tools/deep_memory_profiler/dmprof:839: (policy_label, policy_path,
policy.version))
On 2012/08/08 07:36:53, jochen wrote:
> this might end up accessing .version of None. What about adding an else: path
> that just returns None?

Done.  Thanks for your good catch.

[commit-bot: I haz the power, 2012-08-08 07:54:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10824104/14003

[commit-bot: I haz the power, 2012-08-08 09:41:41]

Change committed as 150528