Issue 10824102: Web Intents Picker: Set minimum size of the inline disposition to 1x1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824102: Web Intents Picker: Set minimum size of the inline disposition to 1x1 (Closed)

Created:
8 years, 4 months ago by gauravsh

Modified:
8 years, 4 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Web Intents Picker: Set minimum size of the inline disposition to 1x1 A value of 0x0 causes an an assertion failure in WebKit's FrameView which doesn't like a 0 min size. BUG=chromium-os:33086 TEST=observed manually on a Chrome OS build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149133

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/intents/web_intent_picker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/10824102/1

8 years, 4 months ago (2012-07-31 02:24:27 UTC) #3

Change committed as 149133

Expand Messages | Collapse Messages