third_party/harfbuzz/src/harfbuzz-gsub.c - Issue 10824101: Harfbuzz roll 3ab7b37bdebf0f8773493a1fee910b151c4de30f

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz/src/harfbuzz-gsub.c

Issue 10824101: Harfbuzz roll 3ab7b37bdebf0f8773493a1fee910b151c4de30f (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: rebased Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz/src/harfbuzz-gsub.c

diff --git a/third_party/harfbuzz/src/harfbuzz-gsub.c b/third_party/harfbuzz/src/harfbuzz-gsub.c

index 21fec51924f122a9726ced2bc843a303dc06fac4..ceb703430dbc2880e0e5f1ed5616f9b0829cd85c 100644

--- a/third_party/harfbuzz/src/harfbuzz-gsub.c

+++ b/third_party/harfbuzz/src/harfbuzz-gsub.c

@@ -3158,13 +3158,13 @@ static HB_Error Lookup_ChainContextSubst2( HB_GSUBHeader* gsub,

if ( error )

return error;

+ if (ccsf2->MaxInputLength < 1)

+ return HB_Err_Not_Covered;

if ( ALLOC_ARRAY( backtrack_classes, ccsf2->MaxBacktrackLength, HB_UShort ) )

return error;

known_backtrack_classes = 0;

- if (ccsf2->MaxInputLength < 1)

- return HB_Err_Not_Covered;

if ( ALLOC_ARRAY( input_classes, ccsf2->MaxInputLength, HB_UShort ) )

goto End3;

known_input_classes = 1;