Fix LINK(DLL) _pyautolib.pyd

Fix LINK(DLL) _pyautolib.pyd

FAILED: C:\Users\binji\dev\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper environment.x86 link.exe /nologo /IMPLIB:_pyautolib.pyd.lib /DLL /OUT:_pyautolib.pyd /PDB:_pyautolib.pyd.pdb @_pyautolib.pyd.rsp
LINK : fatal error LNK1104: cannot open file '../third_party/python_26/libs/python26.lib'

It seems 'libraries' aren't fixed with gyp relative path, so changed it as tools/gyp/test/win/linker-flags/library-directories.gyp does.

BUG=134540
TEST=win trybot and ninja -C out\Release _pyautolib.pyd

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149229

[Nico, 2012-07-31 01:27:51]

Scott gets to decide if this is a gyp generator bug or if we should change
this here (or both) :-)
On Jul 30, 2012 6:06 PM, <ukai@chromium.org> wrote:

> Reviewers: scottmg, Nico,
>
> Description:
> Fix LINK(DLL) _pyautolib.pyd
>
> FAILED: C:\Users\binji\dev\depot_**tools\python_bin\python.exe
> gyp-win-tool
> link-wrapper environment.x86 link.exe /nologo /IMPLIB:_pyautolib.pyd.lib
> /DLL
> /OUT:_pyautolib.pyd /PDB:_pyautolib.pyd.pdb @_pyautolib.pyd.rsp
> LINK : fatal error LNK1104: cannot open file
> '../third_party/python_26/**libs/python26.lib'
>
> It seems 'libraries' aren't fixed with gyp relative path, so changed it as
> tools/gyp/test/win/linker-**flags/library-directories.gyp does.
>
> BUG=134540
> TEST=win trybot and ninja -C out\Release _pyautolib.pyd
>
> Please review this at
http://chromiumcodereview.**appspot.com/10824100/<http://chromiumcodereview.a...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/chrome_tests.gypi
>
>
> Index: chrome/chrome_tests.gypi
> diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
> index 8a5137dcbefa415cc6451db4186759**4671e242f6..**
> 7af6a86faabc96ca40f2601c3119d1**1b1d97b0d9 100644
> --- a/chrome/chrome_tests.gypi
> +++ b/chrome/chrome_tests.gypi
> @@ -4314,10 +4314,15 @@
>                  '..',
>                  '../third_party/python_26/**include',
>                ],
> -              'link_settings': {
> -                'libraries': [
> -                  '../third_party/python_26/**libs/python26.lib',
> -                ],
> +              'msvs_settings': {
> +                'VCLinkerTool': {
> +                  'AdditionalLibraryDirectories'**: [
> +                    '../third_party/python_26/**libs',
> +                  ],
> +                  'AdditionalDependencies': [
> +                    'python26.lib',
> +                  ],
> +                },
>                }
>              }],
>              ['clang == 1', {
>
>
>

[scottmg, 2012-07-31 15:48:48]

|libraries| is a bit weird, most people use -l in there, not paths so I'm not
sure we can relativize them (this is the only place I know of that we have a
path). We could use |AdditionalLibraryDirectories|, but keep python26.lib in
|libraries| instead of |AdditionalDependencies| but I'm not sure it matters.

lgtm

[commit-bot: I haz the power, 2012-07-31 16:00:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ukai@chromium.org/10824100/5001

[commit-bot: I haz the power, 2012-07-31 16:00:13]

Presubmit check for 10824100-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[Nico, 2012-07-31 16:01:51]

lgtm

[commit-bot: I haz the power, 2012-07-31 16:02:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ukai@chromium.org/10824100/5001

[commit-bot: I haz the power, 2012-07-31 18:17:24]

Change committed as 149229