Issue 10824092: [NaCl SDK] Build gtest on buildbots, but don't include it in the SDK.

Issue 10824092: [NaCl SDK] Build gtest on buildbots, but don't include it in the SDK. (Closed)

Created:
8 years, 4 months ago by binji

Modified:
8 years, 4 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Build gtest on buildbots, but don't include it in the SDK. **For now, gtest is marked experimental because the NaCl fix to gtest has not yet been upstreamed and DEPS'd into chrome** * Test-only libraries and examples are build to the $(NACL_SDK_ROOT)testing/ directory. * Added INCLUDES to .dsc file, platform-generic way to add an include directory. BUG=none NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149929

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remove unused function #

Patch Set 4 : sync to HEAD #

Total comments: 1

Patch Set 5 : feedback #

Patch Set 6 : changes so i can land #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -145 lines)			Patch
M	native_client_sdk/src/build_tools/build_sdk.py	View	1 2	5 chunks	+40 lines, -4 lines	0 comments	Download
M	native_client_sdk/src/build_tools/generate_make.py	View	1 2 3 4 5	8 chunks	+23 lines, -19 lines	0 comments	Download
M	native_client_sdk/src/build_tools/make_rules.py	View	1 2 3 4 5	5 chunks	+17 lines, -10 lines	0 comments	Download
D	native_client_sdk/src/libraries/gtest/build.scons	View		1 chunk	+0 lines, -112 lines	0 comments	Download
A	native_client_sdk/src/libraries/gtest/library.dsc	View	1 2 3 4 5	1 chunk	+77 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

noelallen1

LGTM http://codereview.chromium.org/10824092/diff/2003/native_client_sdk/src/build_tools/make_rules.py File native_client_sdk/src/build_tools/make_rules.py (right): http://codereview.chromium.org/10824092/diff/2003/native_client_sdk/src/build_tools/make_rules.py#newcode255 native_client_sdk/src/build_tools/make_rules.py:255: Missing LF

8 years, 4 months ago (2012-07-31 20:37:21 UTC) #2

binji

I have to wait until the gtest NaCl fix is upstreamed (and rolled) before I ...

8 years, 4 months ago (2012-08-01 05:31:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10824092/11002

8 years, 4 months ago (2012-08-03 21:39:00 UTC) #4

Change committed as 149929

Expand Messages | Collapse Messages