Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 10824091: Merge 123377 - Crash when setting empty class name on a new element (Closed)

Created:
8 years, 4 months ago by Stephen Chennney
Modified:
8 years, 4 months ago
Reviewers:
Stephen Chennney
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 123377 - Crash when setting empty class name on a new element https://bugs.webkit.org/show_bug.cgi?id=92024 Reviewed by Andreas Kling. Source/WebCore: Add a check for null attributeData() when setting the className to an empty string on a newly created element. New SVG elements have null attributeData() on baseVal upon creation. Test: svg/custom/empty-className-baseVal-crash.html * dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): Add check for null attributeData() LayoutTests: Add a check for null attributeData() when setting the className to an empty string on a newly created element. * svg/custom/empty-className-baseVal-crash-expected.txt: Added. * svg/custom/empty-className-baseVal-crash.html: Added. TBR=schenney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/svg/custom/empty-className-baseVal-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/empty-className-baseVal-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/dom/StyledElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Stephen Chennney
8 years, 4 months ago (2012-07-30 20:01:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698