Issue 10824084: Fix deserializer to understand direct pointers from code to cell payloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824084: Fix deserializer to understand direct pointers from code to cell payloads. (Closed)

Created:
8 years, 4 months ago by Erik Corry

Modified:
8 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix deserializer to understand direct pointers from code to cell payloads. The deoptimizer generates full-code-generator code and relies on it having the same layout as last time. This means that the code the full code generator makes for the snapshot should be the same as the code it makes later. This change makes the full code generator create more consistent code between mksnapshot time and run time. This is a bug fix and a step towards making the snapshot code more robust. Committed: https://code.google.com/p/v8/source/detail?r=12233

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -135 lines)
M	src/arm/assembler-arm-inl.h	View	1 chunk	+1 line, -4 lines	0 comments
M	src/arm/full-codegen-arm.cc	View	2 chunks	+16 lines, -24 lines	0 comments
M	src/heap.cc	View	1 chunk	+6 lines, -6 lines	0 comments
M	src/ia32/assembler-ia32-inl.h	View	1 chunk	+1 line, -4 lines	0 comments
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+16 lines, -23 lines	1 comment
M	src/mips/assembler-mips-inl.h	View	1 chunk	+1 line, -4 lines	0 comments
M	src/mips/full-codegen-mips.cc	View	2 chunks	+16 lines, -24 lines	0 comments
M	src/objects.h	View	1 chunk	+8 lines, -0 lines	0 comments
M	src/serialize.h	View	1 chunk	+1 line, -1 line	0 comments
M	src/serialize.cc	View	6 chunks	+30 lines, -18 lines	0 comments
M	src/x64/assembler-x64-inl.h	View	1 chunk	+1 line, -4 lines	0 comments
M	src/x64/full-codegen-x64.cc	View	2 chunks	+15 lines, -23 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 4 months ago (2012-07-31 09:02:08 UTC) #2

LGTM with a nit.

https://chromiumcodereview.appspot.com/10824084/diff/1/src/ia32/full-codegen-...
File src/ia32/full-codegen-ia32.cc (right):

https://chromiumcodereview.appspot.com/10824084/diff/1/src/ia32/full-codegen-...
src/ia32/full-codegen-ia32.cc:2495: CallFunctionFlags flags =
RECORD_CALL_TARGET;
nit: This variable is only used once (line 2503), you could inline it just as
you do on x64.

Expand Messages | Collapse Messages