Add WebSocketError to indicate decoding failure reason

net/websockets/websocket_frame_parser.h

Index: net/websockets/websocket_frame_parser.h
diff --git a/net/websockets/websocket_frame_parser.h b/net/websockets/websocket_frame_parser.h
index a6d55ea16355429dd65d8d04115298b3bb1b22d1..1b973c9c904b2d9377e6a23ced7686ad3e60e5f6 100644
--- a/net/websockets/websocket_frame_parser.h
+++ b/net/websockets/websocket_frame_parser.h
@@ -42,6 +42,7 @@ class NET_EXPORT_PRIVATE WebSocketFrameParser {
   // Returns true if the parser has ever failed to decode a WebSocket frame.
   // TODO(yutak): Provide human-readable description of failure.
   bool failed() const { return failed_; }

[mmenke, 2012/08/01 14:44:59]

Do we still need this?  If so, think we should be returning "error_code_ !=
WS_OK", and just get rid of the bool.  That way, shouldn't get any bugs where we
forget to set one or the other.

[Takashi Toyoshima, 2012/08/02 08:11:35]

Ah, that is right.
I'll remove this function and member.

+  WebSocketError error_code() const { return error_code_; }

[mmenke, 2012/08/01 14:44:59]

Suggest calling this websocket_error instead, to make it clearer that this isn't
a generic net error code.

[Takashi Toyoshima, 2012/08/02 08:11:35]

Done.

 
  private:
   // Tries to decode a frame header from |current_read_pos_|.
@@ -75,6 +76,7 @@ class NET_EXPORT_PRIVATE WebSocketFrameParser {
   uint64 frame_offset_;
 
   bool failed_;
+  WebSocketError error_code_;
 
   DISALLOW_COPY_AND_ASSIGN(WebSocketFrameParser);
 };