Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: vm/intermediate_language.h

Issue 10824078: Add explicit PushArgument IL instructions to static calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/il_printer.cc ('k') | vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/intermediate_language.h
===================================================================
--- vm/intermediate_language.h (revision 10004)
+++ vm/intermediate_language.h (working copy)
@@ -695,7 +695,7 @@
intptr_t try_index,
const Function& function,
const Array& argument_names,
- ZoneGrowableArray<Value*>* arguments)
+ ZoneGrowableArray<PushArgumentInstr*>* arguments)
: token_pos_(token_pos),
try_index_(try_index),
function_(function),
@@ -715,16 +715,19 @@
intptr_t try_index() const { return try_index_; }
intptr_t ArgumentCount() const { return arguments_->length(); }
- Value* ArgumentAt(intptr_t index) const { return (*arguments_)[index]; }
+ PushArgumentInstr* ArgumentAt(intptr_t index) const {
+ return (*arguments_)[index];
+ }
MethodRecognizer::Kind recognized() const { return recognized_; }
void set_recognized(MethodRecognizer::Kind kind) { recognized_ = kind; }
- virtual intptr_t InputCount() const;
- virtual Value* InputAt(intptr_t i) const { return ArgumentAt(i); }
- virtual void SetInputAt(intptr_t i, Value* value) {
- (*arguments_)[i] = value;
+ virtual intptr_t InputCount() const { return 0; }
+ virtual Value* InputAt(intptr_t i) const {
+ UNREACHABLE();
+ return NULL;
}
+ virtual void SetInputAt(intptr_t i, Value* value) { UNREACHABLE(); }
virtual void PrintOperandsTo(BufferFormatter* f) const;
@@ -733,7 +736,7 @@
const intptr_t try_index_;
const Function& function_;
const Array& argument_names_;
- ZoneGrowableArray<Value*>* arguments_;
+ ZoneGrowableArray<PushArgumentInstr*>* arguments_;
MethodRecognizer::Kind recognized_;
DISALLOW_COPY_AND_ASSIGN(StaticCallComp);
« no previous file with comments | « vm/il_printer.cc ('k') | vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698