crypto: Tag some overridden methods with OVERRIDE.

crypto: Tag some overridden methods with OVERRIDE.

BUG=115047
R=rsleevi@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148928

[Ryan Sleevi, 2012-07-30 00:59:16]

rubberstamp lgtm with nits

http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc
File crypto/secure_hash_default.cc (right):

http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc#...
crypto/secure_hash_default.cc:29: virtual void Update(const void* input, size_t
len) OVERRIDE {
Please tag as would be done in a .h file, namely

// SecureHash implementation:

(Context: http://www.chromium.org/developers/coding-style#TOC-Code-formatting
"When you implement an interface")

[tfarina, 2012-07-30 01:00:25]

On Sun, Jul 29, 2012 at 9:59 PM,  <rsleevi@chromium.org> wrote:
> rubberstamp lgtm with nits
>
>
> http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc
> File crypto/secure_hash_default.cc (right):
>
>
http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc#...
> crypto/secure_hash_default.cc:29: virtual void Update(const void* input,
> size_t len) OVERRIDE {
> Please tag as would be done in a .h file, namely
>
> // SecureHash implementation:
>
Do you have a preference for this, or can I use // Overridden from SecureHash:
?

-- 
Thiago

[Ryan Sleevi, 2012-07-30 01:02:08]

On Sun, Jul 29, 2012 at 6:00 PM, Thiago Farina <tfarina@chromium.org> wrote:
> On Sun, Jul 29, 2012 at 9:59 PM,  <rsleevi@chromium.org> wrote:
>> rubberstamp lgtm with nits
>>
>>
>> http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc
>> File crypto/secure_hash_default.cc (right):
>>
>>
http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc#...
>> crypto/secure_hash_default.cc:29: virtual void Update(const void* input,
>> size_t len) OVERRIDE {
>> Please tag as would be done in a .h file, namely
>>
>> // SecureHash implementation:
>>
> Do you have a preference for this, or can I use // Overridden from SecureHash:
?
>
> --
> Thiago

http://www.chromium.org/developers/coding-style#TOC-Code-formatting
suggests as I wrote it, and that is largely consistent with existing
code throughout the codebase

[tfarina, 2012-07-30 01:06:58]

On Sun, Jul 29, 2012 at 10:02 PM, Ryan Sleevi <rsleevi@chromium.org> wrote:
> On Sun, Jul 29, 2012 at 6:00 PM, Thiago Farina <tfarina@chromium.org> wrote:
>> On Sun, Jul 29, 2012 at 9:59 PM,  <rsleevi@chromium.org> wrote:
>>> rubberstamp lgtm with nits
>>>
>>>
>>>
http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc
>>> File crypto/secure_hash_default.cc (right):
>>>
>>>
http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc#...
>>> crypto/secure_hash_default.cc:29: virtual void Update(const void* input,
>>> size_t len) OVERRIDE {
>>> Please tag as would be done in a .h file, namely
>>>
>>> // SecureHash implementation:
>>>
>> Do you have a preference for this, or can I use // Overridden from
SecureHash: ?
>>
>> --
>> Thiago
>
> http://www.chromium.org/developers/coding-style#TOC-Code-formatting
> suggests as I wrote it, and that is largely consistent with existing
> code throughout the codebase

Will change, np :)

Is just that in ui/, which I'm more familiar with:

$ g grep "implementation:" ui/ | wc -l
90

$ g grep "Overridden from" ui/ | wc -l
322

;)

-- 
Thiago

[tfarina, 2012-07-30 01:08:12]

http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc
File crypto/secure_hash_default.cc (right):

http://codereview.chromium.org/10824076/diff/1/crypto/secure_hash_default.cc#...
crypto/secure_hash_default.cc:29: virtual void Update(const void* input, size_t
len) OVERRIDE {
On 2012/07/30 00:59:16, Ryan Sleevi wrote:
> Please tag as would be done in a .h file, namely
> 
> // SecureHash implementation:
> 
> (Context: http://www.chromium.org/developers/coding-style#TOC-Code-formatting
> "When you implement an interface")

Done.

[Ryan Sleevi, 2012-07-30 03:54:34]

lgtm

[commit-bot: I haz the power, 2012-07-30 03:54:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/10824076/9001

[commit-bot: I haz the power, 2012-07-30 05:16:01]

Change committed as 148928