Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 10824071: chromeos: output_configurator: various style fixes (Closed)

Created:
8 years, 4 months ago by Simon Que
Modified:
8 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

chromeos: output_configurator: various style fixes - Define member functions of class OutputConfigurator in the order they were declared. - Made struct CachedOutputDescription to be private member of class OutputConfigurator. No need for it to be exposed publicly. - Renamed "enum State" to "enum OutputState" to be more specific. - In places where a large if block extend to the end of the function, use an early return to reduce indentation. BUG=chromium-os:32857 TEST=build successfully Change-Id: Id39dff3b38d16b2496df0df288a332fe29b2e37b Signed-off-by: Simon Que <sque@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -328 lines) Patch
M chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/display/output_configurator.h View 7 chunks +26 lines, -24 lines 0 comments Download
M chromeos/display/output_configurator.cc View 6 chunks +306 lines, -302 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
lgtm
8 years, 4 months ago (2012-07-30 21:31:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/10824071/1
8 years, 4 months ago (2012-07-30 21:33:58 UTC) #2
commit-bot: I haz the power
Presubmit check for 10824071-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 21:34:01 UTC) #3
Simon Que
Requesting review from OWNERS of chrome/browser/ui/webui/options2.
8 years, 4 months ago (2012-07-30 21:38:02 UTC) #4
csilv
chrome/browser/ui/webui/options2 LGTM
8 years, 4 months ago (2012-07-30 21:48:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/10824071/1
8 years, 4 months ago (2012-07-30 21:50:25 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 23:18:52 UTC) #7
Change committed as 149072

Powered by Google App Engine
This is Rietveld 408576698