Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 10824067: Some fixes to run unit_tests bundle on android. (Closed)

Created:
8 years, 4 months ago by nilesh
Modified:
8 years, 4 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Initial fixes to run unit_tests bundle on android. BUG=138115 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148847

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M build/android/pylib/test_package.py View 1 chunk +24 lines, -5 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
nilesh
asanka: Please look at chrome/browser/downloads. bauerb: Please look at chrome/browser/prefs yaron: rest.
8 years, 4 months ago (2012-07-27 19:10:48 UTC) #1
Yaron
lgtm You can probably un-disable a bunch of content_unittests too but we can do that ...
8 years, 4 months ago (2012-07-27 19:14:18 UTC) #2
asanka
http://codereview.chromium.org/10824067/diff/1/chrome/browser/download/download_util.cc File chrome/browser/download/download_util.cc (left): http://codereview.chromium.org/10824067/diff/1/chrome/browser/download/download_util.cc#oldcode171 chrome/browser/download/download_util.cc:171: NOTREACHED(); If this check doesn't apply to OS_ANDROID, I'd ...
8 years, 4 months ago (2012-07-27 19:19:45 UTC) #3
Bernhard Bauer
prefs/ rubber-stamp LGTM
8 years, 4 months ago (2012-07-27 19:31:56 UTC) #4
nilesh
asanka: PTAL. http://codereview.chromium.org/10824067/diff/1/chrome/browser/download/download_util.cc File chrome/browser/download/download_util.cc (left): http://codereview.chromium.org/10824067/diff/1/chrome/browser/download/download_util.cc#oldcode171 chrome/browser/download/download_util.cc:171: NOTREACHED(); On 2012/07/27 19:19:46, asanka wrote: > ...
8 years, 4 months ago (2012-07-27 20:09:25 UTC) #5
asanka
LGTM. Thanks!
8 years, 4 months ago (2012-07-27 20:11:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10824067/4001
8 years, 4 months ago (2012-07-27 20:13:54 UTC) #7
commit-bot: I haz the power
Try job failure for 10824067-4001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-27 22:18:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10824067/4001
8 years, 4 months ago (2012-07-27 22:22:08 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 23:38:07 UTC) #10
Change committed as 148847

Powered by Google App Engine
This is Rietveld 408576698