Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 10824054: add oauth2 zippies to views extension install dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/layout_/layout Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtk/gtk.h> 5 #include <gtk/gtk.h>
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/extensions/bundle_installer.h" 10 #include "chrome/browser/extensions/bundle_installer.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 show_permissions ? content_vbox : left_column_area; 273 show_permissions ? content_vbox : left_column_area;
274 int pixel_width = kLeftColumnMinWidth + 274 int pixel_width = kLeftColumnMinWidth +
275 (show_permissions ? kImageSize : 0); 275 (show_permissions ? kImageSize : 0);
276 276
277 GtkWidget* oauth_issues_header = gtk_util::CreateBoldLabel( 277 GtkWidget* oauth_issues_header = gtk_util::CreateBoldLabel(
278 UTF16ToUTF8(prompt.GetOAuthHeading()).c_str()); 278 UTF16ToUTF8(prompt.GetOAuthHeading()).c_str());
279 gtk_util::SetLabelWidth(oauth_issues_header, pixel_width); 279 gtk_util::SetLabelWidth(oauth_issues_header, pixel_width);
280 gtk_box_pack_start(GTK_BOX(oauth_issues_container), oauth_issues_header, 280 gtk_box_pack_start(GTK_BOX(oauth_issues_container), oauth_issues_header,
281 FALSE, FALSE, 0); 281 FALSE, FALSE, 0);
282 282
283 // TODO(estade): display the issue details under zippies.
284 for (size_t i = 0; i < prompt.GetOAuthIssueCount(); ++i) { 283 for (size_t i = 0; i < prompt.GetOAuthIssueCount(); ++i) {
285 GtkWidget* issue_advice_widget = 284 GtkWidget* issue_advice_widget =
286 CreateWidgetForIssueAdvice(prompt.GetOAuthIssue(i), pixel_width); 285 CreateWidgetForIssueAdvice(prompt.GetOAuthIssue(i), pixel_width);
287 gtk_box_pack_start(GTK_BOX(oauth_issues_container), issue_advice_widget, 286 gtk_box_pack_start(GTK_BOX(oauth_issues_container), issue_advice_widget,
288 FALSE, FALSE, kPermissionsPadding); 287 FALSE, FALSE, kPermissionsPadding);
289 } 288 }
290 } 289 }
291 290
292 g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this); 291 g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);
293 gtk_window_set_resizable(GTK_WINDOW(dialog_), FALSE); 292 gtk_window_set_resizable(GTK_WINDOW(dialog_), FALSE);
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 378
380 } // namespace browser 379 } // namespace browser
381 380
382 void ShowExtensionInstallDialogImpl( 381 void ShowExtensionInstallDialogImpl(
383 gfx::NativeWindow parent, 382 gfx::NativeWindow parent,
384 content::PageNavigator* navigator, 383 content::PageNavigator* navigator,
385 ExtensionInstallPrompt::Delegate* delegate, 384 ExtensionInstallPrompt::Delegate* delegate,
386 const ExtensionInstallPrompt::Prompt& prompt) { 385 const ExtensionInstallPrompt::Prompt& prompt) {
387 new browser::ExtensionInstallDialog(parent, navigator, delegate, prompt); 386 new browser::ExtensionInstallDialog(parent, navigator, delegate, prompt);
388 } 387 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698