Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 10824051: VAVDA: Go back to using vaTerminate now that the bug in the driver is fixed. (Closed)

Created:
8 years, 5 months ago by Pawel Osciak
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Base URL:
https://git.chromium.org/git/chromium/src@master
Visibility:
Public.

Description

VAVDA: Go back to using vaTerminate now that the bug in the driver is fixed. https://gerrit.chromium.org/gerrit/#change,28275 fixes libva-intel-driver to not free the buffer manager before cleaning up BOs, so now vaTerminate can safely be called. Also, since we are using X functions and X Pixmaps with VAAPI, there is no need to use the glx va library just to get the X display. This could have also potentially got us into trouble in the future, so getting rid of it. BUG=138758 TEST=Manual runs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M content/common/gpu/media/vaapi_h264_decoder.cc View 5 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Pawel Osciak
8 years, 5 months ago (2012-07-26 20:10:10 UTC) #1
Ami GONE FROM CHROMIUM
lgtm
8 years, 5 months ago (2012-07-26 20:16:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/10824051/1
8 years, 5 months ago (2012-07-26 20:19:34 UTC) #3
commit-bot: I haz the power
Try job failure for 10824051-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 20:45:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/10824051/1
8 years, 5 months ago (2012-07-26 22:18:05 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-27 01:26:44 UTC) #6
Change committed as 148688

Powered by Google App Engine
This is Rietveld 408576698