Initial change to DEPS to add android_tools repo to third_party.

Initial change to DEPS to add android_tools repo to third_party.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149049

[navabi, 2012-07-26 20:09:24]

The initial submit just adds android_tools to the DEPS for the Android.  Follow
up CL's will do the following:
 1) Add the Android SDK and tools (r20, api version 15)
 2) Add SHA1 version number to android_tools in DEPS file
    (based on #1)
 3) Update Android SDK and tools

[nsylvain, 2012-07-26 20:11:28]

any change the sha1 can be there in the initial cl?

[nsylvain, 2012-07-26 20:11:40]

On 2012/07/26 20:11:28, nsylvain wrote:
> any change the sha1 can be there in the initial cl?

chance, not change

[shashi, 2012-07-26 20:43:33]

lgtm

[navabi, 2012-07-26 22:03:55]

Added SHA1 for initial SDK checkin.  Follow up CL's:
- Add Android NDK to android_tools directory
- Update the SHA1
- Change build commands to point to checked in SDK/NDK and update documentation
appropriately

[Yaron, 2012-07-27 17:36:20]

lgtm

[commit-bot: I haz the power, 2012-07-27 17:36:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/10824050/5001

[commit-bot: I haz the power, 2012-07-27 17:36:53]

Failed to apply patch for DEPS:
While running patch -p1 --forward --force;
patching file DEPS
Hunk #1 FAILED at 471.
1 out of 1 hunk FAILED -- saving rejects to file DEPS.rej

[Isaac (away), 2012-07-27 17:38:59]

lgtm

[nsylvain, 2012-07-27 19:16:29]

lgtm

[navabi, 2012-07-28 00:33:55]

message: I can't seem to upload this change. At first I thought it was the git
cl upload command hanging, but now I'm not so sure.  I let "git cl upload" run
for a long time and got the following error:

...

one processing
/usr/local/google/code/chromium/src/chromeos/display/output_configurator.h
Finished checking
/usr/local/google/code/chromium/src/chrome/app/policy/policy_templates.json. 0
errors, 0 warnings.
Traceback (most recent call last):
  File "/usr/local/google/code/depot_tools/git_cl.py", line 1611, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/code/depot_tools/git_cl.py", line 1596, in main
    return command(parser, argv[1:])
  File "/usr/local/google/code/depot_tools/git_cl.py", line 1134, in CMDupload
    author=None)
  File "/usr/local/google/code/depot_tools/git_cl.py", line 582, in RunHook
    rietveld_obj=self.RpcServer())
  File "/usr/local/google/code/depot_tools/presubmit_support.py", line 1105, in
DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/code/depot_tools/presubmit_support.py", line 1022, in
ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 228, in CheckChangeOnUpload
  File "<string>", line 133, in CheckChange
  File "<string>", line 85, in CheckTODO
IOError: [Errno 2] No such file or directory:
'../ppapi/utility/non_thread_safe_ref_count.h'
Sending crash report ...
  args: ['/usr/local/google/code/depot_tools/git_cl.py', 'upload']
  cwd: /usr/local/google/code/chromium/src/ppapi
  exception: [Errno 2] No such file or directory: '../ppapi/uti
  host: navabi.mtv.corp.google.com
  stack:   File "/usr/local/google/code/depot_tools/git_cl.
  user: navabi
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41)
[GCC 4.
A stack trace has been sent to the maintainers.

Can I submit and bypass the presubmit checks? Do we think that would fix this?

[Isaac (away), 2012-07-28 02:28:47]

you uploaded it normally originally right?

if your rebase was clean should be fine to do the second upload with presubmit
hooks, and use CQ to submit.

[commit-bot: I haz the power, 2012-07-30 20:11:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/10824050/1003

[commit-bot: I haz the power, 2012-07-30 22:19:07]

Change committed as 149049

[Steve Block, 2012-08-01 10:55:24]

You need to add a README.chromium for this new third-party directory. See
'tools/licenses.py scan'. You should also get a review from
open-source-third-party-reviews@google.com. See
http://www.chromium.org/developers/adding-3rd-party-libraries.

[navabi, 2012-08-02 19:17:41]

Will do. Thanks Steve.


On Wed, Aug 1, 2012 at 3:55 AM, <steveblock@chromium.org> wrote:

> You need to add a README.chromium for this new third-party directory. See
> 'tools/licenses.py scan'. You should also get a review from
>
open-source-third-party-**reviews@google.com<open-source-third-party-reviews@....
> See
>
http://www.chromium.org/**developers/adding-3rd-party-**libraries<http://www....
> .
>
>
https://chromiumcodereview.**appspot.com/10824050/<https://chromiumcodereview...
>