Issue 10824049: Disable TCP ports in the default LibjingleTransportFactory() constructor.

Issue 10824049: Disable TCP ports in the default LibjingleTransportFactory() constructor. (Closed)

Created:
8 years, 5 months ago by Sergey Ulanov

Modified:
8 years, 5 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable TCP ports in the default LibjingleTransportFactory() constructor. The default LibjingleTransportFactory is used for tests only. We didn't disable TCP ports even though we do disable them in host and client. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148627

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	remoting/protocol/libjingle_transport_factory.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

simonmorris

lgtm http://codereview.chromium.org/10824049/diff/1/remoting/protocol/libjingle_transport_factory.cc File remoting/protocol/libjingle_transport_factory.cc (right): http://codereview.chromium.org/10824049/diff/1/remoting/protocol/libjingle_transport_factory.cc#newcode327 remoting/protocol/libjingle_transport_factory.cc:327: port_allocator_->set_flags(flags); Maybe remove the flags variable?

8 years, 5 months ago (2012-07-26 19:35:57 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/10824049/diff/1/remoting/protocol/libjingle_transport_factory.cc File remoting/protocol/libjingle_transport_factory.cc (right): http://codereview.chromium.org/10824049/diff/1/remoting/protocol/libjingle_transport_factory.cc#newcode327 remoting/protocol/libjingle_transport_factory.cc:327: port_allocator_->set_flags(flags); On 2012/07/26 19:35:57, simonmorris wrote: > Maybe remove ...

8 years, 5 months ago (2012-07-26 19:59:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10824049/5002

8 years, 5 months ago (2012-07-26 20:00:00 UTC) #4

Change committed as 148627

Expand Messages | Collapse Messages