Force the current card to be blacklisted if all of its features are disabled.

Force the current card to be blacklisted if all of its features are disabled.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149252

[Alexander Potapenko, 2012-07-26 15:46:31]

Folks, WDYT? Is this a right thing to do? Will the call to BlacklistCard()
disable the GPU process completely?

[Zhenyao Mo, 2012-07-26 16:46:53]

On 2012/07/26 15:46:31, Alexander Potapenko wrote:
> Folks, WDYT? Is this a right thing to do? Will the call to BlacklistCard()
> disable the GPU process completely?

No the GPU process can still launch.  Only that all channel connection request
won't go through.  To stop GPU process from launch, you need to check
GpuDataManager::GetInstance()->GpuAccessAllowed() at GPU process launch time.

[Alexander Potapenko, 2012-07-30 09:52:46]

PTAL
With ToT Chrome patch #2 prevents the GPU process from running if all the
features of the card are blacklisted.

[Zhenyao Mo, 2012-07-30 17:03:19]

https://chromiumcodereview.appspot.com/10824044/diff/4001/content/browser/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://chromiumcodereview.appspot.com/10824044/diff/4001/content/browser/gpu...
content/browser/gpu/gpu_process_host.cc:260:
gpu_data_manager->GetGpuFeatureType() == content::GPU_FEATURE_TYPE_ALL)
I think you should also keep the original !GpuAccessAllowed() condition.

[Zhenyao Mo, 2012-07-30 22:57:17]

By the way, apatrick had a similar CL:
https://chromiumcodereview.appspot.com/10832073/, only he handles it at a
different place.

[apatrick_chromium, 2012-07-30 23:42:34]

It's probably better to do it here.

[Alexander Potapenko, 2012-07-31 09:17:55]

https://chromiumcodereview.appspot.com/10824044/diff/4001/content/browser/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://chromiumcodereview.appspot.com/10824044/diff/4001/content/browser/gpu...
content/browser/gpu/gpu_process_host.cc:260:
gpu_data_manager->GetGpuFeatureType() == content::GPU_FEATURE_TYPE_ALL)
On 2012/07/30 17:03:19, Zhenyao Mo wrote:
> I think you should also keep the original !GpuAccessAllowed() condition.

Done.

[Alexander Potapenko, 2012-07-31 09:21:11]

Also, can someone please check the "Commit" box once you're fine with this CL?

[Ken Russell (switch to Gerrit), 2012-07-31 18:06:20]

If Mo gives a thumbs up I'll be glad to as well.

[Zhenyao Mo, 2012-07-31 18:16:00]

LGTM

[Ken Russell (switch to Gerrit), 2012-07-31 18:29:19]

lgtm

[commit-bot: I haz the power, 2012-07-31 18:29:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/10824044/5002

[commit-bot: I haz the power, 2012-07-31 19:48:56]

Change committed as 149252