Issue 10824042: Use linear backing store for hidden properties to save memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824042: Use linear backing store for hidden properties to save memory. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use linear backing store for hidden properties to save memory. R=verwaest@chromium.org BUG=v8:2211 TEST=test-heap/Regress-2211, test-api/HiddenProperties

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+205 lines, -58 lines)			Patch
M	src/objects.h	View	4 chunks	+31 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	7 chunks	+44 lines, -51 lines	0 comments	Download
M	src/objects-inl.h	View	3 chunks	+72 lines, -0 lines	0 comments	Download
M	src/v8globals.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

DBQ: is there any reason why we decided not to compact it even more by ...

8 years, 5 months ago (2012-07-26 13:20:43 UTC) #2

Yang

8 years, 5 months ago (2012-07-26 13:22:16 UTC) #3

On 2012/07/26 13:20:43, Vyacheslav Egorov (Google) wrote:
> DBQ: is there any reason why we decided not to compact it even more by not
> allocating backing store at all if we have only hash hidden property... Smth
> like:
> 
> if hidden_properties->IsNumber() then hidden_properties represents hash
> otherwise it represents a hidden properties backing store.

That sounds like a good idea, for the special case of identity hashes. I'll
explore that.

Expand Messages | Collapse Messages