Issue 10824041: Delete "declarative" permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824041: Delete "declarative" permission. (Closed)

Created:
8 years, 5 months ago by battre

Modified:
8 years, 4 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, Mihai Parparita -not on Chrome, Robert Sesek

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Delete "declarative" permission. BUG=137507 TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148747

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -11 lines)			Patch
M	chrome/common/extensions/docs/apps/fileBrowserHandler.html	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/extensions/declarativeWebRequest.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/extensions/fileBrowserHandler.html	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/static/declarativeWebRequest.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

battre

Could you please have a look at this CL. It removes the "declarative" permission, which ...

8 years, 5 months ago (2012-07-26 13:07:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10824041/1

8 years, 4 months ago (2012-07-27 14:02:00 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-07-27 14:02:04 UTC) #4

Presubmit check for 10824041-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/declarativeWebRequest.html
not reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

Expand Messages | Collapse Messages