Issue 10824039: Rewrite Makefile rules for Android to allow parallel execution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824039: Rewrite Makefile rules for Android to allow parallel execution (Closed)

Created:
8 years, 5 months ago by haitao.feng

Modified:
8 years, 4 months ago

Reviewers:
yangguo, Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Rewrite Makefile rules for Android to allow parallel execution BUG=v8:2257 Committed: https://code.google.com/p/v8/source/detail?r=12211

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -102 lines)			Patch
M	Makefile	View	2 chunks	+8 lines, -5 lines	0 comments	Download
A	Makefile.android	View	1 chunk	+92 lines, -0 lines	0 comments	Download
D	tools/android-build.sh	View	1 chunk	+0 lines, -97 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

Rewrite Makefile rules for Android to allow parallel execution. Basically we want to invoke make ...

8 years, 5 months ago (2012-07-26 07:25:34 UTC) #1

Yang

8 years, 4 months ago (2012-07-27 11:14:35 UTC) #2

On 2012/07/26 07:25:34, haitao.feng wrote:
> Rewrite Makefile rules for Android to allow parallel execution.
> 
> Basically we want to invoke make by the following interface:
>   make $arch.$mode.check -jN
> 
> The problem is that for Android, the arch might be android_ia32 or android_arm
> and they have different configurations of toolchains and gyp_defines. The
> solution is adding an indirection. Previously this is done by
> tools/android-build.sh while it disabled parallel building. 
> 
> Now I rewrite all the android-build.sh logic by using a new Makefile.android:
>   1) There is no "case" statement in Make. Replaced with ifeq/else
> ifeq/else/endif
>   2) It turns out MAKEFILES is a reserved word in Make. If we do not change
the
> name, the "@$(MAKE) -f Makefile.android $@" will search
> out/Makefile.[arm|ia32|x64|mipsel] and things are totally messed.
> 
> Please let me know any issue in the future and I am willing to help :)

LGTM. Landing.

Expand Messages | Collapse Messages